Fix matchnamespacetofolder analyzer/codefix#55424
Conversation
| var targetNamespace = namespaceFromFolders == null | ||
| ? null | ||
| : ConcatNamespace(defaultNamespace, namespaceFromFolders); | ||
| var targetNamespace = PathMetadataUtilities.TryBuildNamespaceFromFolders(document.Folders, syntaxFacts, defaultNamespace); |
There was a problem hiding this comment.
Does this change behavior? The code refactoring didn't have any issues. So I don't get why a change is needed here
There was a problem hiding this comment.
This just cleans up a little since I changed TryBuildNamespaceFromFolders. No change in behavior here, but does ensure that analyzer and refactoring calculate the target the same.
| // to rewrite or move the complex logic. RenameDocumentAsync is designed to behave the same | ||
| // as the intent of this analyzer/codefix pair. | ||
| var targetFolders = PathMetadataUtilities.BuildFoldersFromNamespace(targetNamespace); | ||
| var targetFolders = PathMetadataUtilities.BuildFoldersFromNamespace(targetNamespace, document.Project.DefaultNamespace); |
There was a problem hiding this comment.
The analyzer has already correctly calculated the correct namespace. See the diagnostic message:
Can't we just pass it in the properties bag and avoid recalculating it?
There was a problem hiding this comment.
We already are. The fix here is to avoid duplicating the default namespace. BuildFoldersFromNamespace will build relative folders, but if it doesn't know the default/root namespace it will do it incorrectly.
See how targetNamespace gets assigned. It comes from the analyzer
Fix issues where the namespace for documents at the root would be incorrect.
Fixes: #54757