Skip to content

Make vsix's compatible with vs 2022#55419

Merged
dibarbet merged 1 commit intodotnet:mainfrom
dibarbet:2022_vsix
Aug 6, 2021
Merged

Make vsix's compatible with vs 2022#55419
dibarbet merged 1 commit intodotnet:mainfrom
dibarbet:2022_vsix

Conversation

@dibarbet
Copy link
Copy Markdown
Member

@dibarbet dibarbet commented Aug 4, 2021 •
edited
Loading

Currently attempting to install any VSIX roslyn vsix built in artifacts will only allow installation into vs 2019. VSIX install is a scenario sometimes used for sharing changes with partner teams for validation. @CyrusNajmabadi and @LinglingTong have both encountered this problem. Insertions do not use the vsix installer and are handled separately, so this is not a problem there.

The changes in this PR (per guidance here) make it so our VSIXs are installable into VS 2022. Note that they will not be installable in 2019, but VS 2022 is already a requirement to appropriately build and deploy main anyway.

I verified that after this change I can double click install the vsix into 2022 and that my changes were reflected once installed.

Test insertion - https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/342463
The RPS regressions are the exact same ones we're seeing in main (see this insertion), so counting that as passing

@ghost ghost added the Area-IDE label Aug 4, 2021
@dibarbet dibarbet marked this pull request as ready for review August 5, 2021 07:16
@dibarbet dibarbet requested review from a team as code owners August 5, 2021 07:16
@LinglingTong
Copy link
Copy Markdown
Contributor

LinglingTong commented Aug 5, 2021

This is awesome! Ship it!

@LinglingTong
Copy link
Copy Markdown
Contributor

LinglingTong commented Aug 5, 2021

BTW, will this ILanguageClient change be cherry picked to main https://github.com/dotnet/roslyn/pull/55124/files#diff-52b61250ebbc4bbf85c4be734b6616df51fdf89a46d21f8347b22ecaab0785fbR62? Otherwise LSP scenarios on main may not work I guess?

@dibarbet
Copy link
Copy Markdown
Member Author

dibarbet commented Aug 5, 2021 •
edited
Loading

BTW, will this ILanguageClient change be cherry picked to main https://github.com/dotnet/roslyn/pull/55124/files#diff-52b61250ebbc4bbf85c4be734b6616df51fdf89a46d21f8347b22ecaab0785fbR62? Otherwise LSP scenarios on main may not work I guess?

not until d17p3 ships. main needs to be usable on public VS releases, but the new LSP package versions are only in d17p3

@dibarbet
Copy link
Copy Markdown
Member Author

dibarbet commented Aug 5, 2021

@dotnet/roslyn-compiler I believe I need a couple reviews for the compiler extension source.extension.vsixmanifest changes.

chsienki
chsienki approved these changes Aug 5, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@chsienki chsienki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiler side LGTM

@dibarbet
Copy link
Copy Markdown
Member Author

dibarbet commented Aug 5, 2021

@dotnet/roslyn-compiler for second review (perhaps @RikkiGibson )

@dibarbet dibarbet merged commit e1585f8 into dotnet:main Aug 6, 2021
@ghost ghost added this to the Next milestone Aug 6, 2021
@dibarbet dibarbet deleted the 2022_vsix branch August 6, 2021 17:54
@dibarbet dibarbet modified the milestones: Next, 17.0.P4 Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoeRobich JoeRobich JoeRobich approved these changes

@genlu genlu genlu approved these changes

@RikkiGibson RikkiGibson RikkiGibson approved these changes

@chsienki chsienki chsienki approved these changes

@sharwell sharwell Awaiting requested review from sharwell

@CyrusNajmabadi CyrusNajmabadi Awaiting requested review from CyrusNajmabadi

Assignees

No one assigned

Labels

Area-IDE Area-Infrastructure

Projects

None yet

Milestone

17.0.P4

Development

Successfully merging this pull request may close these issues.

6 participants

@dibarbet @LinglingTong @JoeRobich @genlu @RikkiGibson @chsienki