Skip to content

🐇 Ensure recoverable syntax trees are pushed to temporary storage#55399

Merged
sharwell merged 1 commit intodotnet:mainfrom
sharwell:save-after-parse
Aug 24, 2021
Merged

🐇 Ensure recoverable syntax trees are pushed to temporary storage#55399
sharwell merged 1 commit intodotnet:mainfrom
sharwell:save-after-parse

Conversation

@sharwell
Copy link
Contributor

@sharwell sharwell commented Aug 4, 2021

Ensure recoverable syntax trees transition to weak references on creation, similar to how we handled recoverable text in #45477.

Fixes AB#1307180

@sharwell sharwell requested a review from a team as a code owner August 4, 2021 15:42
@ghost ghost added the Area-IDE label Aug 4, 2021
@sharwell sharwell changed the title Ensure recoverable syntax trees are pushed to temporary storage 🐇 Ensure recoverable syntax trees are pushed to temporary storage Aug 13, 2021
@sharwell
Copy link
Contributor Author

@tmat @CyrusNajmabadi You are the two reviewers from related PR #45477. Can you take a look at this one?

@sharwell sharwell enabled auto-merge August 20, 2021 00:09
@sharwell
Copy link
Contributor Author

@CyrusNajmabadi @tmat can one of you review this one

Copy link
Member

@tmat tmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sharwell sharwell merged commit 31a7399 into dotnet:main Aug 24, 2021
@ghost ghost added this to the Next milestone Aug 24, 2021
@sharwell sharwell deleted the save-after-parse branch August 24, 2021 05:57
@dibarbet dibarbet modified the milestones: Next, 17.0.P4 Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants