Apply reference update operation in ReferenceCleanupService#55386
Merged
dibarbet merged 1 commit intodotnet:release/dev17.0from Aug 4, 2021
Merged
Apply reference update operation in ReferenceCleanupService#55386dibarbet merged 1 commit intodotnet:release/dev17.0from
dibarbet merged 1 commit intodotnet:release/dev17.0from
Conversation
Member
Author
|
cc: @ocallesp |
ryzngard
approved these changes
Aug 3, 2021
ocallesp
approved these changes
Aug 4, 2021
ocallesp
reviewed
Aug 4, 2021
| public VisualStudioReferenceCleanupService(IProjectSystemReferenceCleanupService projectSystemReferenceUpdateService) | ||
| { | ||
| _projectSystemReferenceUpdateService = projectSystemReferenceUpdateService; | ||
| _projectSystemReferenceUpdateService = (IProjectSystemReferenceCleanupService2)projectSystemReferenceUpdateService; |
There was a problem hiding this comment.
With this change It seems that we don't need pr anymore dotnet/project-system#7425
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
TryUpdateReferenceAsyncis no longer implemented by the project system. We can perform the same action by callingGetUpdateReferenceOperationAsyncand applying the operation.