Skip to content

Fix emit of synthesized types nested in a reloadable type#55365

Merged
tmat merged 3 commits intodotnet:mainfrom
tmat:FixEmitOfNestedTypes
Aug 4, 2021
Merged

Fix emit of synthesized types nested in a reloadable type#55365
tmat merged 3 commits intodotnet:mainfrom
tmat:FixEmitOfNestedTypes

Conversation

@tmat
Copy link
Copy Markdown
Member

@tmat tmat commented Aug 3, 2021

Fixes emit for the following scenario:

  [System.Runtime.CompilerServices.CreateNewOnMetadataUpdateAttribute]
  internal class Test
  {
        public void Do()
        {
            Task.Run(async() => {}).Wait();
        }
  }

@tmat tmat requested a review from a team as a code owner August 3, 2021 02:36
@ghost ghost added the Area-Interactive label Aug 3, 2021
@tmat
Copy link
Copy Markdown
Member Author

tmat commented Aug 3, 2021

@davidwengier PTAL
/cc @pranavkm

@tmat
Copy link
Copy Markdown
Member Author

tmat commented Aug 3, 2021

@dotnet/roslyn-compiler

@tmat tmat added this to the 17.0 milestone Aug 3, 2021
@tmat tmat merged commit d04e8ab into dotnet:main Aug 4, 2021
@ghost ghost modified the milestones: 17.0, Next Aug 4, 2021
@tmat tmat deleted the FixEmitOfNestedTypes branch August 4, 2021 15:48
@dibarbet dibarbet modified the milestones: Next, 17.0.P4 Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaredpar jaredpar jaredpar approved these changes

@davidwengier davidwengier davidwengier approved these changes

+1 more reviewer

@cston cston cston approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-Compilers

Projects

None yet

Milestone

17.0.P4

Development

Successfully merging this pull request may close these issues.

5 participants

@tmat @jaredpar @davidwengier @cston @dibarbet