Skip to content

Fix crash with convert namespace#55364

Merged
CyrusNajmabadi merged 3 commits intodotnet:mainfrom
CyrusNajmabadi:convertNamespaceCrash
Aug 3, 2021
Merged

Fix crash with convert namespace#55364
CyrusNajmabadi merged 3 commits intodotnet:mainfrom
CyrusNajmabadi:convertNamespaceCrash

Conversation

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

Oopsie.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner August 3, 2021 02:29
@ghost ghost added the Area-IDE label Aug 3, 2021
@CyrusNajmabadi CyrusNajmabadi changed the title Convert namespace crash Fix crash with convert namespace Aug 3, 2021
</PropertyGroup>
<ItemGroup>
<PackageReference Include="System.Collections.Immutable" Version="$(SystemCollectionsImmutableVersion)" />
<PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="$(MicrosoftNETFrameworkReferenceAssembliesVersion)" />
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope!

@CyrusNajmabadi CyrusNajmabadi merged commit 3a5457c into dotnet:main Aug 3, 2021
@ghost ghost added this to the Next milestone Aug 3, 2021
@CyrusNajmabadi CyrusNajmabadi deleted the convertNamespaceCrash branch August 3, 2021 17:44
@dibarbet dibarbet modified the milestones: Next, 17.0.P4 Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants