Move IAddMissingImportsFeatureService to use OOP#55318
Merged
ryzngard merged 4 commits intodotnet:mainfrom Aug 5, 2021
Merged
Conversation
…us from getting semantic data inproc if OOP is enabled.
Contributor
|
I'll try to get to this this weekend. If I can't, long me on Monday! Thanks! |
Contributor
Author
This can definitely wait until Monday @CyrusNajmabadi |
1 similar comment
Contributor
Author
This can definitely wait until Monday @CyrusNajmabadi |
Contributor
Author
|
ping @JoeRobich @CyrusNajmabadi if you have some time |
JoeRobich
approved these changes
Aug 3, 2021
| @@ -52,15 +51,17 @@ public async Task<Document> AddMissingImportsAsync(Document document, AddMissing | |||
| public async Task<AddMissingImportsAnalysisResult> AnalyzeAsync(Document document, TextSpan textSpan, CancellationToken cancellationToken) | |||
| { | |||
| // Get the diagnostics that indicate a missing import. | |||
Member
There was a problem hiding this comment.
Stale comment
Suggested change
| // Get the diagnostics that indicate a missing import. |
…ervice.cs Co-authored-by: Joey Robichaud <jorobich@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IAddMissingImportsFeatureService wraps IAddImportFeatureService with some logic for reducing fixes that will be taken. The work to get diagnostics was previously done inproc, which can be expensive. This moves that work to IAddImportFeatureService via a new
GetUniqueFixesAsyncapi and utilizes OOP when possible