Turn off LSP TextEdit completion feature flag by default#55252
Merged
allisonchou merged 1 commit intorelease/dev17.0from Jul 30, 2021
Merged
Turn off LSP TextEdit completion feature flag by default#55252allisonchou merged 1 commit intorelease/dev17.0from
allisonchou merged 1 commit intorelease/dev17.0from
Conversation
NTaylorMullen
approved these changes
Jul 29, 2021
davidwengier
approved these changes
Jul 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought by turning the feature flag on only for internal users, then external users wouldn't be affected. It turns out I was wrong and if the feature flag doesn't exist, the default value is used (which in this case is on). Thanks to Taylor for the catch!
This change turns off the flag by default for everyone.