React to changes in .net6p7 to how source generated file paths are created#55245
Merged
dibarbet merged 1 commit intodotnet:release/dev17.0from Jul 30, 2021
Merged
React to changes in .net6p7 to how source generated file paths are created#55245dibarbet merged 1 commit intodotnet:release/dev17.0from
dibarbet merged 1 commit intodotnet:release/dev17.0from
Conversation
Member
Author
|
@jinujoseph this is coming in for m2/ QB - EnC diagnostics in razor will be broken as soon as they finish inserting the net6p7 SDK into VS p3 without this change |
Member
Author
|
fyi @allisonchou an M2 change we can try and get in tomorrow, otherwise it should be good for qb too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there were a couple changes to file paths for source generated docs in net6p7 causing enc diagnostics in razor to fail. This must go into VS p3 since net6p7 will soon be added to VS p3.
Prior to net6p7 we looked for file paths like: "Microsoft.NET.Sdk.Razor.SourceGenerators\Microsoft.NET.Sdk.Razor.SourceGenerators.RazorSourceGenerator\_Pages_Counter_razor.cs"
In net6p7, this changed to: "Microsoft.NET.Sdk.Razor.SourceGenerators\Microsoft.NET.Sdk.Razor.SourceGenerators.RazorSourceGenerator\Pages_Counter_razor.g.cs"
Note the .g.cs and the missing underscore at the begining of the name