Fix regression in recursive patterns#55208
Merged
jcouv merged 2 commits intodotnet:release/dev17.0from Jul 29, 2021
Merged
Conversation
RikkiGibson
approved these changes
Jul 29, 2021
| { | ||
| Debug.Assert(recursive.HasAnyErrors); | ||
| tests.Add(new Tests.One(new BoundDagTypeTest(recursive.Syntax, ErrorType(), input, hasErrors: true))); | ||
| continue; |
Member
There was a problem hiding this comment.
nit: seems like continue skips just a single statement here so 'else' may be preferable
333fred
approved these changes
Jul 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking back at the change in
MakeTestsAndBindingsForRecursivePatternfor the extended property patterns, I see that the behavior in error case changed a bit. It used to bail, avoiding continuing toMakeTestsAndBindings. This PR restores that behavior.Although we do have some tests for error cases (such as
ExtendedPropertyPatterns_BadMemberAccess) they happen to use patterns that are compatible with the original input type, so didn't hit this crash.Fixes #55184