Introduce Parameter: Do not show code action if highlighted expression's parent is member access expression#55143
Merged
akhera99 merged 1 commit intodotnet:mainfrom Jul 27, 2021
Conversation
…to introduce a parameter
|
|
||
| // Need to special case for expressions whose direct parent is a MemberAccessExpression since they will | ||
| // never introduce a parameter that makes sense in that case. | ||
| if (syntaxFacts.IsNameOfAnyMemberAccessExpression(expression)) |
Contributor
There was a problem hiding this comment.
so, i don't have an objection to ths. but what you're doing is building a disallow-list. When that happens we should always ask: should this be an allow-list instead. Specifically, should we instead be enumerating the set of cases we know are valid to extract as opposed to trying to enumerate the set of cases that should be blocking?
Member
Author
There was a problem hiding this comment.
I was thinking about this when looking at the code, but I feel like enumerating the cases that are allowed would be more lengthy than the blocking list.
ryzngard
approved these changes
Jul 27, 2021
davidwengier
approved these changes
Jul 27, 2021
Member
davidwengier
left a comment
There was a problem hiding this comment.
Thanks for doing this @akhera99
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #54878