Don't use DefaultInterpolatedStringHandler in expression trees#55125
Merged
333fred merged 3 commits intodotnet:mainfrom Jul 27, 2021
Merged
Don't use DefaultInterpolatedStringHandler in expression trees#55125333fred merged 3 commits intodotnet:mainfrom
333fred merged 3 commits intodotnet:mainfrom
Conversation
Introduces a binder flag to track whether we are currently in an expression tree or not. Fixes dotnet#55114.
9d0e52e to
d29bc18
Compare
Member
Author
|
@dotnet/roslyn-compiler for review. |
jcouv
reviewed
Jul 27, 2021
jcouv
reviewed
Jul 27, 2021
jcouv
reviewed
Jul 27, 2021
jcouv
reviewed
Jul 27, 2021
Member
jcouv
left a comment
There was a problem hiding this comment.
Done with review pass (iteration 2)
chsienki
reviewed
Jul 27, 2021
Member
Author
chsienki
approved these changes
Jul 27, 2021
jcouv
reviewed
Jul 27, 2021
| IL_0087: pop | ||
| IL_0088: ret | ||
| } | ||
| "); |
Member
There was a problem hiding this comment.
nit: I had a different kind of test in mind (less noisy), possibly using ExpressionTestLibrary, but I guess this works too. Sorry, I should have been specific.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a binder flag to track whether we are currently in an expression tree or not. Fixes #55114.