Use new LSP packages to provide better failure notifications#55124
Merged
dibarbet merged 4 commits intorelease/dev17.0-vs-depsfrom Jul 28, 2021
Merged
Use new LSP packages to provide better failure notifications#55124dibarbet merged 4 commits intorelease/dev17.0-vs-depsfrom
dibarbet merged 4 commits intorelease/dev17.0-vs-depsfrom
Conversation
32432b5 to
7a3d919
Compare
Member
Author
|
@mgoertz-msft could you take a quick look at the xaml changes and ensure they match your expectations |
Contributor
|
Looks good. Thank you @dibarbet! |
Contributor
|
Looks good to me. Thanks @dibarbet ! |
davidwengier
approved these changes
Jul 27, 2021
Member
davidwengier
left a comment
There was a problem hiding this comment.
Love the explanatory comments for each ShowNotificaiton method <3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Responds to LSP breaking changes.
TODO - finish test insertion