Change default level to warning to avoid creating 100gb sized log files#55071
Merged
dibarbet merged 1 commit intodotnet:mainfrom Jul 23, 2021
Merged
Change default level to warning to avoid creating 100gb sized log files#55071dibarbet merged 1 commit intodotnet:mainfrom
dibarbet merged 1 commit intodotnet:mainfrom
Conversation
…d creating 100gb sized log files
davidwengier
approved these changes
Jul 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The real fix is on the LSP client side to recycle live logs (while VS is open).
That is tracked here for next sprint - https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1359778/ (I would consider this a blocker for fully enabling lsp pull diagnostics)
However to avoid destroying my VS if I leave it on with pull diagnostics for a couple hours, I'm changing the default logging level.
I also abstracted out the loghub log creation code into a mef service as part 1 of #55060 (vs lsp client will be re-used in VSMac, so we need to move the AbstractInProcLanguageClient code down to editor features)