Fix 'move type' with file scoped namespaces#55020
Merged
CyrusNajmabadi merged 4 commits intodotnet:mainfrom Jul 22, 2021
Merged
Fix 'move type' with file scoped namespaces#55020CyrusNajmabadi merged 4 commits intodotnet:mainfrom
CyrusNajmabadi merged 4 commits intodotnet:mainfrom
Conversation
|
Azure Pipelines successfully started running 3 pipeline(s). |
ryzngard
reviewed
Jul 21, 2021
| } | ||
|
|
||
| [WpfFact, Trait(Traits.Feature, Traits.Features.CodeActionsMoveType)] | ||
| public async Task MoveTypeWithWithFileScopedNamespace() |
Contributor
There was a problem hiding this comment.
Can you add a tests for moving Class1 and Class2 with this setup? Assuming this is valid with filescoped namespaces
namespace N1;
class Class1
{
Nested.Class2 C2 { get; }
}
namespace Nested
{
class Class2 { }
}
Contributor
Author
There was a problem hiding this comment.
that's not valid. it's illegal to mix/match a file-scoped namespace with any other sort of namespace (including another file scoped namespace).
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
Author
|
ping @ryzngard |
ryzngard
approved these changes
Jul 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to test plan: #49000