Update version of cloudcache lib we reference#55016
Merged
CyrusNajmabadi merged 5 commits intodotnet:mainfrom Jul 24, 2021
Merged
Update version of cloudcache lib we reference#55016CyrusNajmabadi merged 5 commits intodotnet:mainfrom
CyrusNajmabadi merged 5 commits intodotnet:mainfrom
Conversation
CyrusNajmabadi
commented
Jul 21, 2021
| ExtraLarge, | ||
| } | ||
|
|
||
| private const int Iterations = 100; |
Contributor
Author
There was a problem hiding this comment.
note: even running all tests 100 times each, we still run all sqlite and cloudcache tests in under 30s total. so this seems worth it for the coverage.
dibarbet
reviewed
Jul 21, 2021
| <MicrosoftServiceHubFrameworkVersion>2.8.10</MicrosoftServiceHubFrameworkVersion> | ||
| <MicrosoftVisualBasicVersion>10.1.0</MicrosoftVisualBasicVersion> | ||
| <MicrosoftVisualStudioCacheVersion>16.10.40-alpha</MicrosoftVisualStudioCacheVersion> | ||
| <MicrosoftVisualStudioCacheVersion>17.0.13-alpha</MicrosoftVisualStudioCacheVersion> |
Member
There was a problem hiding this comment.
might need to go into main-vs-deps unless we're shipping this in VS, I don't think we've merged dev17 back into main yet (though hopefully soon)
Contributor
Author
There was a problem hiding this comment.
main-vs-deps already has this. this is to unblock main through from teh test failures we're seeing there. do you know when we're going to be on dev17 for main? @jinujoseph ?
Member
There was a problem hiding this comment.
I believe we're waiting on preview2 images? @allisonchou was working on it actively if I remember right
7ead146 to
8c91de0
Compare
dibarbet
approved these changes
Jul 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #54869