Don't combine 'this.' with underscore named fields#54975
Merged
CyrusNajmabadi merged 6 commits intodotnet:mainfrom Jul 20, 2021
Merged
Don't combine 'this.' with underscore named fields#54975CyrusNajmabadi merged 6 commits intodotnet:mainfrom
CyrusNajmabadi merged 6 commits intodotnet:mainfrom
Conversation
JoeRobich
approved these changes
Jul 20, 2021
ryzngard
reviewed
Jul 20, 2021
|
|
||
| public D(int _) | ||
| { | ||
| this._ = _; |
Contributor
There was a problem hiding this comment.
Is this even correct anymore?
Contributor
Author
There was a problem hiding this comment.
yeah, i'll revert the tests.
ryzngard
approved these changes
Jul 20, 2021
davidwengier
approved these changes
Jul 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The point of hte naming is to make it clear that it's a private instance field. So it's redundant to state
this.to access it. Note that these cases are the outliers and more than 99% of all field accesses (yes, i checked) do not usethis.