Notify Pythia when item is being committed#54964
Merged
genlu merged 2 commits intodotnet:mainfrom Jul 22, 2021
Merged
Conversation
Member
Author
|
Sync'd with Intellicode team, LSP support for this callback can be added in future. |
ryzngard
approved these changes
Jul 21, 2021
dibarbet
reviewed
Jul 21, 2021
| // Make sure the notification isn't sent on UI thread. | ||
| await TaskScheduler.Default; | ||
| await notifyProvider.NotifyCommittingItemAsync(document, roslynItem, commitCharacter, cancellationToken).ConfigureAwait(false); | ||
| }); |
Member
There was a problem hiding this comment.
should we track exceptions with a reportnonfatalerror since this is fire and forget?
Also for tests, should this also be covered under an async listener - it also might make the test simpler as you can just wait for the async operation to complete
Member
Author
There was a problem hiding this comment.
Makes sense, fixed. As of the test, since there's only one, I will just keep it as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #53712
Question for @dibarbet @allisonchou If/how this can be hooked up in LSP?