Enable LSP completion experiment for all internal users and change name#54858
Merged
allisonchou merged 1 commit intodotnet:mainfrom Jul 16, 2021
Merged
Conversation
davidwengier
approved these changes
Jul 16, 2021
dibarbet
approved these changes
Jul 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A VS PM reached out and asked if I could change the name of the LSP completion experiment (using TextEdits, implemented in #51166). In the process, I thought it would be helpful to turn on the experiment for all internal Microsoft users to gather more feedback before we eventually go on-by-default for everyone. Note this flag only affects LSP scenarios and should not affect the default Roslyn completion experience. Users can also turn the flag off if they find perf is not good enough.