Skip to content

Fix RPS issues in Razor options service#54857

Merged
allisonchou merged 2 commits intodotnet:mainfrom
allisonchou:FixRPSIssuesRazorOptions
Jul 16, 2021
Merged

Fix RPS issues in Razor options service#54857
allisonchou merged 2 commits intodotnet:mainfrom
allisonchou:FixRPSIssuesRazorOptions

Conversation

@allisonchou
Copy link
Copy Markdown
Contributor

Fixes Razor RPS regressions by lazily loading LanguageServerClient.Razor.dll and moves ExternalAccess.Razor.dll inside an existing dll.

See Taylor's comment in this PR for additional details on the issue: https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/332314

@allisonchou allisonchou added Area-IDE LSP issues related to the roslyn language server protocol implementation labels Jul 16, 2021
@allisonchou allisonchou requested review from a team as code owners July 16, 2021 06:13
@allisonchou
Copy link
Copy Markdown
Contributor Author

Note, I also included #54228 in this PR since it touches the same code.

@allisonchou allisonchou merged commit 417bad8 into dotnet:main Jul 16, 2021
@ghost ghost added this to the Next milestone Jul 16, 2021
@allisonchou allisonchou deleted the FixRPSIssuesRazorOptions branch July 16, 2021 20:10
@allisonchou allisonchou modified the milestones: Next, 17.0.P3 Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE LSP issues related to the roslyn language server protocol implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants