Implements support for reloadable types in the compiler#54852
Merged
tmat merged 6 commits intodotnet:mainfrom Jul 20, 2021
Merged
Implements support for reloadable types in the compiler#54852tmat merged 6 commits intodotnet:mainfrom
tmat merged 6 commits intodotnet:mainfrom
Conversation
Member
Author
|
@davidwengier PTAL |
src/Compilers/CSharp/Test/Emit/Emit/EditAndContinue/EditAndContinueTests.cs
Outdated
Show resolved
Hide resolved
Member
|
Surprisingly simple (so far??) |
Member
Author
Haha, yeah it takes an effort to make things simple :) |
Member
Absolutely! A few lines of code and 20+ years of experience to write them :) |
120b768 to
2fc0ec4
Compare
Member
Author
|
@dotnet/roslyn-compiler PTAL |
cston
reviewed
Jul 20, 2021
cston
reviewed
Jul 20, 2021
cston
reviewed
Jul 20, 2021
src/Compilers/VisualBasic/Portable/Emit/EditAndContinue/VisualBasicSymbolMatcher.vb
Outdated
Show resolved
Hide resolved
cston
approved these changes
Jul 20, 2021
RikkiGibson
approved these changes
Jul 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a type marked as "reloadable" is edited a new type with synthesized name
{original-name}#{N}is emitted instead of updating the original type in-place (N is the generation ordinal).Implements compiler support for emitting EnC deltas with reloadable types in EmitDifference. Adds a new
SemanticEditKind.Replaceto mark an edit as a replacement an existing type with its new version.IDE changes using this API will come in a follow-up PR.
Contributes to #49006