Skip to content

Change feature flag title#54841

Merged
dibarbet merged 1 commit intodotnet:mainfrom
dibarbet:update_flag_title
Jul 16, 2021
Merged

Change feature flag title#54841
dibarbet merged 1 commit intodotnet:mainfrom
dibarbet:update_flag_title

Conversation

@dibarbet
Copy link
Copy Markdown
Member

was requested by VS core to align with other feature flag names.

@dibarbet dibarbet added Area-IDE LSP issues related to the roslyn language server protocol implementation labels Jul 15, 2021
@dibarbet dibarbet requested a review from a team as a code owner July 15, 2021 17:42
@dibarbet dibarbet changed the title Change feature flag name Change feature flag title Jul 15, 2021
Copy link
Copy Markdown
Member

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless all of the other feature flags are changing, this seems like it makes it less consistent ¯\_(ツ)_/¯

Copy link
Copy Markdown
Member

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless all of the other feature flags are changing, this seems like it makes it less consistent ¯\_(ツ)_/¯

@davidwengier
Copy link
Copy Markdown
Member

Thanks GitHub!

@dibarbet
Copy link
Copy Markdown
Member Author

dibarbet commented Jul 16, 2021

Unless all of the other feature flags are changing, this seems like it makes it less consistent ¯_(ツ)_/¯

I believe they're reaching out to everyone, so hopefully consistent soon™

@dibarbet dibarbet merged commit 2e52301 into dotnet:main Jul 16, 2021
@ghost ghost added this to the Next milestone Jul 16, 2021
@dibarbet dibarbet deleted the update_flag_title branch July 16, 2021 07:39
@allisonchou allisonchou modified the milestones: Next, 17.0.P3 Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE LSP issues related to the roslyn language server protocol implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants