Non behavioral cleanup to the lexer prior to raw string work.#54790
Merged
CyrusNajmabadi merged 3 commits intodotnet:mainfrom Jul 13, 2021
Merged
Non behavioral cleanup to the lexer prior to raw string work.#54790CyrusNajmabadi merged 3 commits intodotnet:mainfrom
CyrusNajmabadi merged 3 commits intodotnet:mainfrom
Conversation
CyrusNajmabadi
commented
Jul 13, 2021
| { | ||
| var quoteCharacter = TextWindow.PeekChar(); | ||
| if (quoteCharacter == '\'' || quoteCharacter == '"') | ||
| Debug.Assert(quoteCharacter == '\'' || quoteCharacter == '"'); |
Contributor
Author
There was a problem hiding this comment.
no need for if check here.
CyrusNajmabadi
commented
Jul 13, 2021
| public bool allowNewlines; | ||
| private readonly Lexer _lexer; | ||
| private bool _isVerbatim; | ||
| private bool _allowNewlines; |
Contributor
Author
There was a problem hiding this comment.
made private and renamed.
CyrusNajmabadi
commented
Jul 13, 2021
| internal partial class Lexer | ||
| { | ||
| private void ScanStringLiteral(ref TokenInfo info, bool allowEscapes = true) | ||
| private void ScanStringLiteral(ref TokenInfo info, bool inDirective) |
Contributor
Author
There was a problem hiding this comment.
renamed, inverted and made non-optional.
333fred
approved these changes
Jul 13, 2021
Member
333fred
left a comment
There was a problem hiding this comment.
LGTM (commit 3). @dotnet/roslyn-compiler for a second review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shoudl be reviewed with whitespace changes off.