Skip to content

Add F# content type to always active server to support pull diagnostics#54701

Merged
dibarbet merged 1 commit intodotnet:mainfrom
dibarbet:fsharp_pull_diag
Jul 9, 2021
Merged

Add F# content type to always active server to support pull diagnostics#54701
dibarbet merged 1 commit intodotnet:mainfrom
dibarbet:fsharp_pull_diag

Conversation

@dibarbet
Copy link
Copy Markdown
Member

@dibarbet dibarbet commented Jul 9, 2021

Currently, when LSP pull diagnostics are enabled, F# diagnostics disappear because we're no longer tagging and publishing to the error list. This fixes it by supporting F# requests for pull diagnostics.

Before (with flag enabled)
image

After (with flag enabled)
image

@dibarbet dibarbet requested review from a team as code owners July 9, 2021 00:46
@ghost ghost added the Area-IDE label Jul 9, 2021
@dibarbet dibarbet merged commit 7e53c46 into dotnet:main Jul 9, 2021
@dibarbet dibarbet deleted the fsharp_pull_diag branch July 9, 2021 07:36
@ghost ghost added this to the Next milestone Jul 9, 2021
@allisonchou allisonchou modified the milestones: Next, 17.0.P3 Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants