Enable CA2012 (Use ValueTasks correctly)#54697
Merged
sharwell merged 2 commits intodotnet:mainfrom Jul 13, 2021
Merged
Conversation
| if (isEnabledValueTask.IsCompleted) | ||
| return isEnabledValueTask.Result; | ||
|
|
||
| isEnabledValueTask.Preserve(); |
Contributor
Author
There was a problem hiding this comment.
For ValueTask backed by constants or Task, nothing. But for ones backed by IValueTaskSource (which can pool), registers a continuation that calls GetResult to return the source lease.
Contributor
Author
There was a problem hiding this comment.
➡️ Changed the code to use Forget instead of Preserve, plus the commit links to microsoft/vs-threading#556.
Member
|
Oops, sorry. That button is easy to hit accidentally in the GitHub iOS app! |
CyrusNajmabadi
approved these changes
Jul 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.