Revert "Ensure we don't try and build an empty table when modifying entries"#54664
Merged
allisonchou merged 1 commit intorelease/dev17.0from Jul 8, 2021
Merged
Revert "Ensure we don't try and build an empty table when modifying entries"#54664allisonchou merged 1 commit intorelease/dev17.0from
allisonchou merged 1 commit intorelease/dev17.0from
Conversation
Member
|
I'm lacking some context. Why are we reverting this? |
Member
Author
|
It doesn't meet the QB bar. However there's not currently an urgent need to merge this (no QB changes currently coming in via this branch). Will hand this PR off to @allisonchou. |
jcouv
approved these changes
Jul 7, 2021
ryzngard
approved these changes
Jul 7, 2021
JoeRobich
approved these changes
Jul 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #54647
cc @allisonchou @dibarbet @chsienki