Skip to content

Remove unneeded prototype#54645

Merged
jcouv merged 1 commit intodotnet:features/caller-argument-expressionfrom
Youssef1313:patch-12
Jul 7, 2021
Merged

Remove unneeded prototype#54645
jcouv merged 1 commit intodotnet:features/caller-argument-expressionfrom
Youssef1313:patch-12

Conversation

@Youssef1313
Copy link
Copy Markdown
Member

@Youssef1313 Youssef1313 commented Jul 6, 2021

Proposal: dotnet/csharplang#287
Test plan: #52745

I think current behavior matches LDM decision:
https://github.com/dotnet/csharplang/blob/d91eab3660ef80159cecd76ad89456cc2607cadd/meetings/2021/LDM-2021-06-14.md#span-of-the-expression

Conclusion
Option 3: we go from the start of real C# executable code to the end of the expression, not including any leading or trailing trivia.

@Youssef1313 Youssef1313 requested a review from a team as a code owner July 6, 2021 22:26
@ghost ghost added the Area-Compilers label Jul 6, 2021
@jcouv
Copy link
Copy Markdown
Member

jcouv commented Jul 6, 2021

Do we have other tests that cover the behavior described by LDM decision? Or is that tracked as a follow-up somewhere?


In reply to: 875138982

@jcouv jcouv self-assigned this Jul 6, 2021
@Youssef1313
Copy link
Copy Markdown
Member Author

Youssef1313 commented Jul 6, 2021

Do we have other tests that cover the behavior described by LDM decision? Or is that tracked as a follow-up somewhere?

There are other tests for comments.
TestGoodCallerArgumentExpressionAttribute_ExpressionHasTrivia

Copy link
Copy Markdown
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@jcouv jcouv merged commit fd2a03f into dotnet:features/caller-argument-expression Jul 7, 2021
@Youssef1313 Youssef1313 deleted the patch-12 branch July 7, 2021 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants