Additional cleanup to FAR engine.#54644
Merged
CyrusNajmabadi merged 5 commits intodotnet:mainfrom Jul 7, 2021
Merged
Conversation
CyrusNajmabadi
commented
Jul 6, 2021
| /// Implementations of this method must be thread-safe. | ||
| /// </summary> | ||
| Task<ImmutableArray<Project>> DetermineProjectsToSearchAsync( | ||
| ISymbol symbol, Solution solution, IImmutableSet<Project>? projects, CancellationToken cancellationToken); |
Contributor
Author
There was a problem hiding this comment.
there was exactly one implementation of this method, with no sublcasses overriding it. So i just inlined the one impl at teh callsite.
CyrusNajmabadi
commented
Jul 7, 2021
| namespace Microsoft.CodeAnalysis.FindSymbols | ||
| { | ||
| using ProjectToDocumentMap = Dictionary<Project, Dictionary<Document, HashSet<(SymbolGroup group, ISymbol symbol, IReferenceFinder finder)>>>; | ||
| using ProjectToDocumentMap = Dictionary<Project, Dictionary<Document, HashSet<ISymbol>>>; |
Contributor
Author
There was a problem hiding this comment.
instead of passing around the symbol group through everything, it can be computed and cached right before we notify the FAR listeners.
Contributor
Author
|
This is ready for review. |
dibarbet
approved these changes
Jul 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #54641. That should go in first.
Should be reviewed with whitespace off.