[LSP] Temporary workaround for Razor documents returning null tokens#54548
Merged
allisonchou merged 1 commit intodotnet:mainfrom Jul 2, 2021
Merged
Conversation
NTaylorMullen
approved these changes
Jul 1, 2021
| RequestContext context, | ||
| CancellationToken cancellationToken) | ||
| { | ||
| // Temporary workaround for https://github.com/dotnet/roslyn/issues/54547: |
| { | ||
| // Temporary workaround for https://github.com/dotnet/roslyn/issues/54547: | ||
| // We should eventually go back to throwing here if context.Document is null. | ||
| if (context.Document is null) |
Contributor
There was a problem hiding this comment.
oh... boy do i hate this. IMO this is not ok and we need to revert this PR. This is precisely teh sort of "limp along when we dont' know what is happening" approach that leads to extreme amounts of tech debt and an inability to reason about what's going on.
Contributor
This is not a good reason. The logs are telling us that something has gone critically wrong. It is not ok to solve that by just having our code ignore hte issue. If anything, we should be prioritizing determining the root cause asap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary workaround for #54547. Mainly just to clean up the noise in logs until a cleaner, long-term solution is added.