Reduce overheads of NullOperationListener.Delay#54517
Merged
sharwell merged 3 commits intodotnet:mainfrom Jul 2, 2021
Merged
Conversation
Contributor
|
I was literally right in the middle of this 🤣 |
sharwell
reviewed
Jul 1, 2021
src/Workspaces/Core/Portable/Shared/TestHooks/AsynchronousOperationListener.cs
Outdated
Show resolved
Hide resolved
This is showing up as a primary source of cancellation exceptions while creating projects in VS.
sharwell
approved these changes
Jul 1, 2021
11e056b to
81a5b57
Compare
...ore/Portable/Shared/TestHooks/AsynchronousOperationListenerProvider+NullOperationListener.cs
Outdated
Show resolved
Hide resolved
...ore/Portable/Shared/TestHooks/AsynchronousOperationListenerProvider+NullOperationListener.cs
Show resolved
Hide resolved
Contributor
|
Is Delay0WithAsync meaningful? I'm curiosu the codepaths doing that. |
Member
Author
Based on what I saw of current usage, I don't believe so. I included it in my local microbenchmarks just for completeness. |
…ationListenerProvider+NullOperationListener.cs Co-authored-by: CyrusNajmabadi <cyrus.najmabadi@gmail.com>
stephentoub
commented
Jul 1, 2021
...ore/Portable/Shared/TestHooks/AsynchronousOperationListenerProvider+NullOperationListener.cs
Show resolved
Hide resolved
…ationListenerProvider+NullOperationListener.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is showing up as a primary source of first-chance cancellation exceptions while creating projects in VS.
On .NET Framework 4.8:
On .NET 6.0: