Fix OptProf drop path in 16.10#54516
Merged
JoeRobich merged 1 commit intorelease/dev16.10from Jul 1, 2021
Merged
Conversation
We fixed the drop path a while ago in other branches but forgot about 16.10, and it's causing OptProf test to break after we inserted a new build from dnceng pipeline recently. Fixed it in this branch too just in case PR in VS that's fixing the drop issue: https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/335189
RikkiGibson
approved these changes
Jul 1, 2021
Member
RikkiGibson
left a comment
There was a problem hiding this comment.
change LGTM, I don't think we need to wait for the roslyn-ci outage to be resolved in order to merge.
Member
Author
|
@JoeRobich Feel free to force merge this :) |
Member
|
Merging to fix optprof |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We fixed the drop path a while ago in other branches (#53722) but forgot about 16.10, and it's causing OptProf test to break after we inserted a new build from dnceng pipeline recently. Fixed it in this branch too just in case
PR in VS that's fixing the drop issue:
https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/335189