Completion: Conditional access on nullable parameter suggests Nullable members#54491
Merged
CyrusNajmabadi merged 6 commits intodotnet:mainfrom Jul 1, 2021
Merged
Conversation
…type in GetMemberSymbolsForParameter
Youssef1313
reviewed
Jun 30, 2021
| { | ||
| void M(System.DateTime? dt) | ||
| { | ||
| dt?.$$ |
Member
There was a problem hiding this comment.
Consider adding another test without the normal member access (dt.$$)
Contributor
Author
There was a problem hiding this comment.
You are right. Due to the unconditionally RemoveNullableIfPresent, dt.$$ suggest DateTime members, which is wrong. Good catch.
Contributor
Author
Youssef1313
reviewed
Jun 30, 2021
| } | ||
| "; | ||
| await VerifyItemExistsAsync(markup, "Day"); | ||
| await VerifyItemIsAbsentAsync(markup, "value"); |
Member
There was a problem hiding this comment.
Typo? Should this have been Value?
Contributor
Author
There was a problem hiding this comment.
CopyPaste from the test above. Will fix it.
Youssef1313
reviewed
Jun 30, 2021
Member
Youssef1313
left a comment
There was a problem hiding this comment.
Consider adding a test for VB as well.
Contributor
Author
CyrusNajmabadi
approved these changes
Jul 1, 2021
Contributor
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #54361
Root cause is here:
roslyn/src/Workspaces/CSharp/Portable/Recommendations/CSharpRecommendationServiceRunner.cs
Lines 463 to 468 in 1b9f72f
The
containerSymbolwas fixed before withRemoveNullableIfPresent, but the parameter symbols type is not. This PR fixes this inGetMemberSymbolsForParameter.