✨ Implement ImmutableSegmentedList<T>#54424
Merged
sharwell merged 11 commits intodotnet:mainfrom Jul 22, 2021
Merged
Conversation
These types are copied from dotnet/runtime@v6.0.0-preview.5.21301.5.
Youssef1313
reviewed
Jun 28, 2021
Youssef1313
reviewed
Jun 28, 2021
Youssef1313
reviewed
Jun 28, 2021
src/Dependencies/Collections/ImmutableSegmentedList`1+Builder.cs
Outdated
Show resolved
Hide resolved
Forgind
approved these changes
Jul 1, 2021
Contributor
Forgind
left a comment
There was a problem hiding this comment.
Looks good to me! Questions as promised 🙂
Contributor
Author
|
@dotnet/roslyn-compiler for reviews |
sharwell
commented
Jul 8, 2021
src/Dependencies/Collections/ImmutableSegmentedList`1+ValueBuilder.cs
Outdated
Show resolved
Hide resolved
* Document IListCalls and related types * Clarify comments in code * Clear ImmutableSegmentedList<T>.ValueBuilder._list when initializing _mutableList
534b6f1 to
30a0e82
Compare
Contributor
Author
|
@CyrusNajmabadi any other issues here? @dotnet/roslyn-compiler for reviews |
Contributor
Author
|
@dotnet/roslyn-compiler for reviews |
jaredpar
approved these changes
Jul 22, 2021
chsienki
approved these changes
Jul 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This type relates to
SegmentedList<T>in the same way thatImmutableSegmentedDictionary<TKey, TValue>relates toSegmentedDictionary<TKey, TValue>./cc @rainersigwald