Skip to content

Fix incorrect unit test code sample in source generator docs#54320

Merged
jcouv merged 2 commits intodotnet:mainfrom
scharnyw:sg-cookbook-ut
Jul 14, 2021
Merged

Fix incorrect unit test code sample in source generator docs#54320
jcouv merged 2 commits intodotnet:mainfrom
scharnyw:sg-cookbook-ut

Conversation

@scharnyw
Copy link
Copy Markdown
Contributor

The GeneratedSources property is defined on the Microsoft.CodeAnalysis.Testing.ProjectState class, not the Microsoft.CodeAnalysis.CSharp.Testing.CSharpSourceGeneratorTest class. So the sample code provided in source generator cookbook was incorrect and did not compile. Fixed by moving it to the correct place.

@ghost ghost added the Area-Compilers label Jun 23, 2021
@scharnyw scharnyw requested a review from sharwell June 30, 2021 03:10
Copy link
Copy Markdown
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 2)

@jcouv jcouv self-assigned this Jul 14, 2021
@jcouv jcouv merged commit 2946c61 into dotnet:main Jul 14, 2021
@ghost ghost added this to the Next milestone Jul 14, 2021
@jcouv
Copy link
Copy Markdown
Member

jcouv commented Jul 14, 2021

Merged/squashed. Thanks @scharnyw

@allisonchou allisonchou modified the milestones: Next, 17.0.P3 Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants