Simplify unnecessary condition#54133
Merged
jcouv merged 2 commits intodotnet:features/caller-argument-expressionfrom Jun 17, 2021
Merged
Simplify unnecessary condition#54133jcouv merged 2 commits intodotnet:features/caller-argument-expressionfrom
jcouv merged 2 commits intodotnet:features/caller-argument-expressionfrom
Conversation
333fred
approved these changes
Jun 17, 2021
Member
|
@dotnet/roslyn-compiler for a second small review. |
Member
|
Merged/squashed. Thanks @Youssef1313 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the length should be guaranteed to be
1in this code path since we check forAttributeDescription.CallerArgumentExpressionAttribute.Note: I initially wrote it that way since it was nearly a copy/paste from other code here:
roslyn/src/Compilers/CSharp/Portable/Symbols/Source/SourceComplexParameterSymbol.cs
Lines 776 to 782 in 1f5c03e
If my thought is correct, the other code could be simplified as well.
Test plan: #52745