Conversation
…ssage if the message is not a KeyValueMessage
dibarbet
left a comment
There was a problem hiding this comment.
I'm OK with this - but we'll probably start getting a lot more telemetry than before (just looking at all the usages of https://sourceroslyn.io/#Microsoft.CodeAnalysis.Workspaces/Logger.cs,18836a2d7350ee49)
Are there any that we should be removing, or is the plan to just see what new events we get and suppress later?
I should probably move LogBlock to follow same rules as Log. I added LogLevel specifically so we could provide logging on any kind of message, and the logger provides how. VSTelemetry should send anything >= Information |
Update the VSTelemetryLogger to include the message property of LogMessage if the message is not a KeyValueMessage