Enable nullable reference types integration test harness#53590
Merged
sharwell merged 2 commits intodotnet:mainfrom May 28, 2021
Merged
Enable nullable reference types integration test harness#53590sharwell merged 2 commits intodotnet:mainfrom
sharwell merged 2 commits intodotnet:mainfrom
Conversation
ryzngard
approved these changes
May 26, 2021
Contributor
ryzngard
left a comment
There was a problem hiding this comment.
I did my best to go through this, but it's a lot of content. So take my review as
- Nothing stands out
- If there are problems, it's not failing any current tests or build
- We can always fix as needed later if needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code includes a higher than average use of assertions like
Contract.ThrowIfNull. This should help narrow down cases where flaky integration tests produce unexpected intermediate results.