Skip to content

Binding zoom level to Inheritance margin#53534

Merged
Cosifne merged 1 commit intodotnet:release/dev16.11from
Cosifne:dev/shech/InheritanceMarginBugsFix
May 28, 2021
Merged

Binding zoom level to Inheritance margin#53534
Cosifne merged 1 commit intodotnet:release/dev16.11from
Cosifne:dev/shech/InheritanceMarginBugsFix

Conversation

@Cosifne
Copy link
Member

@Cosifne Cosifne commented May 20, 2021

Binding to zoom level of TextView to ScaleFactor of CrispImage.
I
Before:
image

After:
image

@Cosifne Cosifne requested a review from a team as a code owner May 20, 2021 06:56
@ghost ghost added the Area-IDE label May 20, 2021
Copy link
Member

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this fixes #53372 perhaps?

Copy link
Contributor

@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cosifne
Copy link
Member Author

Cosifne commented May 20, 2021

Looks like this fixes #53372 perhaps?

Yes

@sharwell sharwell dismissed their stale review May 20, 2021 22:00

It appears that the editor recreates glyphs when the zoom level changes

@Cosifne Cosifne changed the base branch from release/dev16.11-vs-deps to release/dev16.11 May 27, 2021 18:13
@Cosifne
Copy link
Member Author

Cosifne commented May 28, 2021

@vatsalyaagrawal for approval

@Cosifne Cosifne merged commit 9f1db5e into dotnet:release/dev16.11 May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants