Add OmniSharpInlineHintsService to ExternalAccess#53533
Merged
333fred merged 4 commits intodotnet:release/dev16.11from May 26, 2021
Merged
Add OmniSharpInlineHintsService to ExternalAccess#53533333fred merged 4 commits intodotnet:release/dev16.11from
333fred merged 4 commits intodotnet:release/dev16.11from
Conversation
After consuling with @CyrusNajmabadi and @akhera99, I believe we should be OK to add IInlineHintsService to the OmniSharp ExternalAccess layer, so that they can take advantage of the proposed vscode APIs and leverage our existing implementation without having to rewrite.
Member
Author
|
After talking with @jasonmalinowski I've additionally added access to IFindDefinitionService. |
Member
Author
|
@CyrusNajmabadi @akhera99 @jasonmalinowski can I get reviews please? |
src/Tools/ExternalAccess/OmniSharp/Navigation/OmniSharpNavigableItem.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
May 25, 2021
333fred
commented
May 25, 2021
src/Tools/ExternalAccess/OmniSharp/InlineHints/OmniSharpInlineHintsService.cs
Outdated
Show resolved
Hide resolved
src/Tools/ExternalAccess/OmniSharp/Navigation/OmniSharpNavigableItem.cs
Outdated
Show resolved
Hide resolved
333fred
commented
May 25, 2021
src/Tools/ExternalAccess/OmniSharp/InlineHints/OmniSharpInlineHintsService.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
@sharwell master of ExternalAccess, can you please take a look? |
Member
Author
|
@jinujoseph can I get approval to merge this in 16.11? For reference, this is an ExternalAccess API for OmniSharp, and we don't want to be using a 4.0 binary there yet so I'm putting it in 3.11. No impact on VS should be noticed. |
Contributor
|
@jinujoseph this should be safe (no impact) for 16.11. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After consuling with @CyrusNajmabadi and @akhera99, I believe we should be OK to add IInlineHintsService to the OmniSharp ExternalAccess layer, so that they can take advantage of the proposed vscode APIs and leverage our existing implementation without having to rewrite.