Fix dnceng build by forcing the use of xcopy msbuild#53530
Merged
JoeRobich merged 1 commit intorelease/dev16.9from May 20, 2021
Merged
Fix dnceng build by forcing the use of xcopy msbuild#53530JoeRobich merged 1 commit intorelease/dev16.9from
JoeRobich merged 1 commit intorelease/dev16.9from
Conversation
jmarolf
approved these changes
May 20, 2021
Contributor
|
😕 I don't understand how the title of this commit/PR matches the implementation. |
Member
Author
In our global.json we define our minimum VS version as 16.8. By moving to a queue with VS2017, Arcade will see that we do not meet the minimum required and instead use the 16.8 xcopy package of msbuild. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing build with this change https://dev.azure.com/dnceng/internal/_build/results?buildId=1146951&view=results (Microsoft only)