EnC - Update CustomAttributes table instead of just always adding to it#53507
Merged
davidwengier merged 37 commits intodotnet:mainfrom Jun 16, 2021
Merged
EnC - Update CustomAttributes table instead of just always adding to it#53507davidwengier merged 37 commits intodotnet:mainfrom
davidwengier merged 37 commits intodotnet:mainfrom
Conversation
cston
reviewed
May 19, 2021
src/Compilers/Core/Portable/Emit/EditAndContinue/DeltaMetadataWriter.cs
Outdated
Show resolved
Hide resolved
cston
reviewed
May 19, 2021
src/Compilers/CSharp/Test/Emit/Emit/EditAndContinue/EditAndContinueTests.cs
Show resolved
Hide resolved
davidwengier
commented
May 20, 2021
src/Compilers/CSharp/Test/Emit/Emit/EditAndContinue/EditAndContinueTests.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
@tmat given dotnet/runtime#53066 I wonder if this change in behaviour should be based on the runtime capabilities, so that downlevel frameworks aren't affected? I don't think its an enourmous issue since the issue already exists in those frameworks, so its probably not causing issues due to reflection caching, but the most cautious approach would be to only change behaviour for .NET 6 and up. |
tmat
reviewed
May 26, 2021
src/Compilers/Core/Portable/Emit/EditAndContinue/DeltaMetadataWriter.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
May 26, 2021
tmat
reviewed
May 26, 2021
src/Compilers/Core/Portable/Emit/EditAndContinue/DeltaMetadataWriter.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
May 26, 2021
src/Compilers/Core/Portable/Emit/EditAndContinue/DeltaMetadataWriter.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
May 26, 2021
src/Compilers/Core/Portable/Emit/EditAndContinue/DeltaMetadataWriter.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
May 26, 2021
src/Compilers/Core/Portable/Emit/EditAndContinue/DeltaMetadataWriter.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
May 26, 2021
src/Compilers/Core/Portable/Emit/EditAndContinue/DeltaMetadataWriter.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Jun 10, 2021
src/Compilers/Core/Portable/Emit/EditAndContinue/DeltaMetadataWriter.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Jun 10, 2021
src/Compilers/Core/Portable/Emit/EditAndContinue/DeltaMetadataWriter.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Jun 10, 2021
src/Compilers/Core/Portable/Emit/EditAndContinue/DeltaMetadataWriter.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Jun 10, 2021
src/Compilers/Core/Portable/Emit/EditAndContinue/DeltaMetadataWriter.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Jun 10, 2021
src/Compilers/Core/Portable/Emit/EditAndContinue/DeltaMetadataWriter.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
Apologies @tmat that you had to read all of that, the new code with binary search is much simpler, much easier to understand, and was much easier to write. |
tmat
reviewed
Jun 14, 2021
src/Compilers/Core/Portable/Emit/EditAndContinue/DeltaMetadataWriter.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Jun 14, 2021
src/Compilers/Core/Portable/Emit/EditAndContinue/DeltaMetadataWriter.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Jun 14, 2021
src/Compilers/Core/Portable/Emit/EditAndContinue/DeltaMetadataWriter.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Jun 14, 2021
| code: EditAndContinueOperation.Default); | ||
| } | ||
|
|
||
| void AddLogEntryOrDelete(int rowId, EntityHandle parent, bool add) |
Member
Member
Author
There was a problem hiding this comment.
Naming on this one was hard. It either adds an EncLog entry, or it creates a "delete" custom attribute and adds it to the list for later emitting.
tmat
reviewed
Jun 14, 2021
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jaredpar
approved these changes
Jun 15, 2021
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #52816
This doesn't do anything for deletes yet, need to decide if we will, and how. Previously we didn't care about changes that were only visible through reflection, but now that reflection caches are cleared that maybe isn't fair. Though re-orders then probably need to be changed too? Need to discuss.