Skip to content

Report obsoletion diagnostics for slice and indexer#53421

Closed
Youssef1313 wants to merge 1 commit intodotnet:mainfrom
Youssef1313:obsolete-indexer-slice
Closed

Report obsoletion diagnostics for slice and indexer#53421
Youssef1313 wants to merge 1 commit intodotnet:mainfrom
Youssef1313:obsolete-indexer-slice

Conversation

@Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented May 14, 2021

Fixes #53418

Should this be documented as a breaking change?

@Youssef1313 Youssef1313 requested a review from a team as a code owner May 14, 2021 11:28
@ghost ghost added the Area-Compilers label May 14, 2021
@Youssef1313 Youssef1313 force-pushed the obsolete-indexer-slice branch from 925444a to 8dcd392 Compare May 14, 2021 11:46
Comment on lines 7929 to 7930
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea if hasBaseReceiver is correct here.

@Youssef1313 Youssef1313 force-pushed the obsolete-indexer-slice branch from 8dcd392 to 91345e1 Compare May 14, 2021 12:25
@AlekseyTs
Copy link
Contributor

@Youssef1313 You are sending PRs for an untriaged issue. This is probably not a good idea because we haven't yet made a determination if the issue is a bug and whether we want to fix it.

@AlekseyTs AlekseyTs closed this May 14, 2021
@Youssef1313 Youssef1313 deleted the obsolete-indexer-slice branch May 14, 2021 14:12
@Youssef1313 Youssef1313 restored the obsolete-indexer-slice branch May 17, 2021 18:10
@Youssef1313 Youssef1313 deleted the obsolete-indexer-slice branch August 11, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Obsolete members are not reported for implicit range indexer

2 participants