Update to ICSharpCode.Decompiler 7.1.0.6543#53304
Conversation
|
|
| { | ||
| // This method is not called by the decompiler | ||
| throw new NotSupportedException(); | ||
| return Task.Run(() => Resolve(name)); |
There was a problem hiding this comment.
is this intentional that we are trying to move this to a dedicated threadpool thread to do this work?
There was a problem hiding this comment.
As pointed out, I took it from our implementation - any other way is fine with me that fits your needs.
|
Should we have this target 16.11? @sharwell? |
|
We released https://github.com/icsharpcode/ILSpy/releases/tag/v7.1 yesterday. To update the PR, it would need to be added to the feed. |
|
@christophwille @sharwell TL;DR: VS Debugger needs this PR or a similar update PR to get merged into Roslyn and inserted into VS. |
|
Azure Pipelines successfully started running 3 pipeline(s). |
I submitted a request to add them. |
|
@christophwille I'm fixing the tests and will push the updates to this PR. |
|
This has now been sitting around for quite some time even after Sam's update to the latest infra changes. Is there a plan to merge this? |
|
I'll ping the internal thread for this |
|
Test Insertion - https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/352300 (microsoft) |
|
@sharwell Test insertion was passing. |
|
So. One month later from me last asking. Any news (you can share)? |
|
Should we close this pull request as there is no progress (indication) for months? |
|
Finally had a meeting today. Should have this resolved/merged by the end of the month at the latest. |
For new language features (mostly C# 9.0) see https://github.com/icsharpcode/ILSpy/releases/tag/v7.0
IAssemblyResolver implemented as per https://github.com/icsharpcode/ILSpy/blame/dfd82de1afdb7d897d1c0084856a84197ac8fd20/ICSharpCode.Decompiler/Metadata/UniversalAssemblyResolver.cs#L213-L221