Skip to content

Use patterns#53290

Merged
CyrusNajmabadi merged 9 commits intodotnet:mainfrom
CyrusNajmabadi:usePattern
May 10, 2021
Merged

Use patterns#53290
CyrusNajmabadi merged 9 commits intodotnet:mainfrom
CyrusNajmabadi:usePattern

Conversation

@CyrusNajmabadi
Copy link
Contributor

Followup to #53288

@ghost ghost added the Area-IDE label May 9, 2021
@CyrusNajmabadi CyrusNajmabadi marked this pull request as ready for review May 10, 2021 03:49
@CyrusNajmabadi CyrusNajmabadi requested review from a team as code owners May 10, 2021 03:49
var operationParent = (IPropertyReferenceOperation)operation.Parent;
var parentProperty = operationParent.Property.Name;
if (parentProperty != nameof(System.Type.Name) && parentProperty != "Name")
if (parentProperty is not nameof(System.Type.Name))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was a manual change as these two constants are identical.

@CyrusNajmabadi CyrusNajmabadi merged commit d4e8ed5 into dotnet:main May 10, 2021
@ghost ghost added this to the Next milestone May 10, 2021
@CyrusNajmabadi CyrusNajmabadi deleted the usePattern branch May 10, 2021 08:05
@RikkiGibson RikkiGibson modified the milestones: Next, 17.0.P2 Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants