Improve far multi-targetting grouping for one more case.#53281
Merged
CyrusNajmabadi merged 1 commit intodotnet:mainfrom May 10, 2021
Merged
Improve far multi-targetting grouping for one more case.#53281CyrusNajmabadi merged 1 commit intodotnet:mainfrom
CyrusNajmabadi merged 1 commit intodotnet:mainfrom
Conversation
CyrusNajmabadi
commented
May 8, 2021
| // they are linked into. | ||
| if (!seenLocations.Add((declarationLocation.Document.FilePath, declarationLocation.SourceSpan))) | ||
| continue; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
thie code was literally not necessary. TryCreateDocumentSpanEntryAsync already contains the merging code that checks if the declarationLocation is a dupe, and if so, 'combines all the flavors' to make a suitable 'project bucket' for it to belong to.
davidwengier
approved these changes
May 9, 2021
Member
davidwengier
left a comment
There was a problem hiding this comment.
Note to self: Put in small bits of low hanging fruit so I can follow up later and feel productive 😛
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous work to improve multi-targetting didn't properly merge all information in all situations. This could lead to the UI showing:
I had alreayd fixed the lower level merging code, so thsi extract check i added in one location undid it. Removing the check gives the desirable result of: