Skip to content

Add localization from OneLocBuild (2021-05-07)#53258

Merged
1 commit merged intodotnet:release/dev16.10-vs-depsfrom
jonfortescue:OneLocBuild-25fbbb44-f11b-4110-94f6-2fa5959b4a6d
May 11, 2021
Merged

Add localization from OneLocBuild (2021-05-07)#53258
1 commit merged intodotnet:release/dev16.10-vs-depsfrom
jonfortescue:OneLocBuild-25fbbb44-f11b-4110-94f6-2fa5959b4a6d

Conversation

@jonfortescue
Copy link
Contributor

@jonfortescue jonfortescue commented May 7, 2021

Among other things, this fixes AB#1321419

@jonfortescue jonfortescue requested review from a team as code owners May 7, 2021 17:07
@jonfortescue jonfortescue requested a review from a team May 7, 2021 17:07
@ghost ghost added the Area-Infrastructure label May 7, 2021
@jonfortescue jonfortescue requested a review from jaredpar May 7, 2021 17:09
<trans-unit id="Consecutive_braces_must_not_have_a_blank_between_them">
<source>Consecutive braces must not have blank line between them</source>
<target state="new">Consecutive braces must not have blank line between them</target>
<target state="translated">Po sobě jdoucí závorky nesmí mít mezi sebou prázdný řádek.</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonfortescue Notice several strings have added ending punctuation that isn't present in the original string. Other strings in this file seem to preserve the lack of ending punctuation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it is helpful for me to point out each occurence of this but it occurs in many other strings in many of the .xlf files being changed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say leave them for now. Cristiano will report them and they'll be fixed in a future update.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless specified in the note section (by adding comments in the resx), translations will use the appropriated rules of the local grammar. Some languages will require punctuation in complete sentences.
Do you need the punctuation out?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add notes for each string whether it is intended to be used on its own or combined into a more complete string. As a rule, we add punctuation when we are intending strings to be complete sentences. In this case, these are fragments that are concatenated together to form diagnostic messages.

Do you recommend we start marking up each string? Is that how other projects are handling this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<trans-unit id="Consecutive_braces_must_not_have_a_blank_between_them">
<source>Consecutive braces must not have blank line between them</source>
<target state="new">Consecutive braces must not have blank line between them</target>
<target state="translated">Aufeinanderfolgende geschweifte Klammern dürfen keine leere Zeile einschließen.</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue with ending punctuation.

@jonfortescue jonfortescue requested a review from wli3 May 7, 2021 21:36
@wli3
Copy link

wli3 commented May 10, 2021

@JoeRobich please merge it now. For actual translation error please follow up with @cristianosuzuki77

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit 686a9e9 into dotnet:release/dev16.10-vs-deps May 11, 2021
@jonfortescue jonfortescue deleted the OneLocBuild-25fbbb44-f11b-4110-94f6-2fa5959b4a6d branch May 11, 2021 20:54
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants