Null annotate and add some checks for SymbolFinder.cs#53246
Merged
jasonmalinowski merged 1 commit intodotnet:mainfrom May 7, 2021
Merged
Conversation
jasonmalinowski
commented
May 7, 2021
Member
Author
There was a problem hiding this comment.
All callers were checking first, so removed the null support instead.
davidwengier
approved these changes
May 7, 2021
CyrusNajmabadi
approved these changes
May 7, 2021
The Contract.ThrowIfNull() in InlineMethod is safe (I think) because of 8d59b35 where we previously filtered it out.
eff0f66 to
ed4be4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.