Skip to content

Add progress bar to the top of value tracking#53206

Merged
ryzngard merged 4 commits intodotnet:features/value_trackingfrom
ryzngard:features/value_tracking_progress_ui
May 19, 2021
Merged

Add progress bar to the top of value tracking#53206
ryzngard merged 4 commits intodotnet:features/value_trackingfrom
ryzngard:features/value_tracking_progress_ui

Conversation

@ryzngard
Copy link
Contributor

@ryzngard ryzngard commented May 6, 2021

@ryzngard ryzngard added the Feature - IDE Value Tracking Work being done for Value Tracking in the IDE label May 6, 2021
@ryzngard ryzngard requested a review from mikadumont May 6, 2021 01:37
@ryzngard ryzngard requested a review from a team as a code owner May 6, 2021 01:37
@ghost ghost added the Area-IDE label May 6, 2021
@Cosifne
Copy link
Member

Cosifne commented May 6, 2021

From the gif above, would it be better to expand the progress to the whole window ? Like Test Explorer in VS?
image

@Cosifne
Copy link
Member

Cosifne commented May 6, 2021

Also, I feel it might be confusing to leave the tree item blank during loading.
I would expected something like this to indicate we are loading something
image

@Cosifne
Copy link
Member

Cosifne commented May 6, 2021

And one last thought (not a blocking issue for this PR, might be something in the future)
I have seen a lot of places in VS, like the FAR window
image

Test Explorer
image

When the 'tree view' item is selected, the blue selection extends to the end.

On earth they are all customized ListView instead of tree view. Since we are having more and more tree view like UI in the future I feel we might need to create our own in Roslyn and applies all of them to our current UI.

@ryzngard
Copy link
Contributor Author

ryzngard commented May 7, 2021

Updated the top gif to the new iteration @Cosifne

@ryzngard ryzngard requested review from Cosifne and davidwengier May 7, 2021 21:40
Copy link
Member

@Cosifne Cosifne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐱‍👤
Overall Good.
Have some naming issues, but they should be easy to resolve

@ryzngard ryzngard enabled auto-merge May 19, 2021 21:57
@ryzngard ryzngard merged commit 2ab7887 into dotnet:features/value_tracking May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE Feature - IDE Value Tracking Work being done for Value Tracking in the IDE

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants