Workaround bug in LSP client in 16.10p2 in integration tests#53127
Merged
dibarbet merged 1 commit intorelease/dev16.10from May 4, 2021
Merged
Workaround bug in LSP client in 16.10p2 in integration tests#53127dibarbet merged 1 commit intorelease/dev16.10from
dibarbet merged 1 commit intorelease/dev16.10from
Conversation
that do not complete before solution close are never completed or cleared from the task list. This manifests as hangs when a new solution is opened in features that wait for all LSP server activation tasks to complete.
58b3da0 to
56d69fa
Compare
davidwengier
approved these changes
May 4, 2021
Member
Author
|
@jinujoseph or @vatsalyaagrawal - I want to get this test-only integration test fix into the 16.10 branch so that our 16.10 / 16.11 qb changes are able to run integration tests when the queue upgrades. This doesn't need to be inserted though since it's a test only change. Is it good to go in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LSP client has a bug in 16.10p2 where server activation tasks that are not completed will never get completed if the solution is closed. Then when a solution is re-opened, these activation tasks are not cleared, so features that wait for LSP to initialize just hang on these never completing tasks.
The fix comes in two parts:
This is fixed on the LSP client side in 16.10p3, but this should prevent us from breaking when the queue switches over to 16.10p2
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1322125
TODO:
✅
Target 16.10✅
Make sure tests pass on 16.10p2 queue (a few times)