Skip to content

Fix caret placement for argument completion snippets#53040

Merged
sharwell merged 1 commit intodotnet:release/dev16.10from
sharwell:caret-placement
Apr 30, 2021
Merged

Fix caret placement for argument completion snippets#53040
sharwell merged 1 commit intodotnet:release/dev16.10from
sharwell:caret-placement

Conversation

@sharwell
Copy link
Contributor

Prior to this change, the caret placement for the end of an argument completion snippet was offset from the start of the arguments instead of the end.

When completing a method call for object.Equals, the change in caret placement is:

-object.Equals(n$$ull)
+object.Equals(null)$$

@sharwell sharwell requested a review from a team as a code owner April 29, 2021 23:44
@ghost ghost added the Area-IDE label Apr 29, 2021
@jinujoseph jinujoseph added this to the 16.10.P3 milestone Apr 29, 2021
@sharwell sharwell enabled auto-merge April 29, 2021 23:56
@sharwell sharwell merged commit 8d08e88 into dotnet:release/dev16.10 Apr 30, 2021
@sharwell sharwell deleted the caret-placement branch January 13, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants